Added Safari Extention #63
Conversation
Safari extention added. Works for group Chats but not for Individual chats
|
Is there any way to prevent the code duplication? |
|
I actually started learning about making extensions about 24 hours ago, so at this time, I really don't know how to answer your questions. This, and SpotiAds are my first commits to github |
|
Also, the feature seems to be working fine on both individual and group chats. I must've not tested correctly previousl |
|
This looks good, I think the only problem is the duplication of code files. If you can find a way to not need that and still have the same repo for both Chrome and Safari it'd be great. If not, we can just have a link to your fork for those who want Safari support. The same is true for SpotiAds. |
|
I have figured out to package It into a single binary so that we only need share only 1 file, but I am not sure if it will work for everyone. It runs on my computer as I built it, but since I am not enrolled in Apple's Paid Developer program, Binaries signed by me might not work for others. Will update once I have researched more. Also, you can check out the directory structure of https://github.com/ajayyy/SponsorBlock as they have all extensions in one repo. Tho the Distribution method is quite different |
|
Hello @tomer8007 @taksh108 Does restore deleted messages works with Safari WebView 'WKWebView' ? |
|
@vivekwarde I don't know, never tested it. |
|
@vivekwarde this has been too long, I don't remember much tbh. Haven't worked on anything on safari in years |
|
@tomer8007 @taksh108 In Safari WebView WKStoreKit, WKWebView I have tested that no last seen, no blue tick, no story seen works perfectly but restore deleted messages doesn't works at all. Can you please guide me how to get it solved/working? Its Either some mistake in our implementation or some mistake in your code... |
Safari extention added. Works for group Chats but not for Individual chats