Skip to content

Commit

Permalink
tests: revert last commit, --editable requires a VCS URL
Browse files Browse the repository at this point in the history
Signed-off-by: Stephen L. <lrq3000@gmail.com>
  • Loading branch information
lrq3000 committed May 11, 2023
1 parent 9b2ab62 commit b24076f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-build-downstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ jobs:
# Note: we need to install BEFORE so that we can install our update package reedsolo after (with cutting edge git version), and force pyFileFixity to use it (otherwise we would need to disable isolation build in pip if placed after, but it would be more messy).
# FIXME: Need to use the @ form once issue https://github.com/pypa/pip/issues/11951 is fixed, as supplying extras to an egg fragment is deprecated and will be removed in pip v25.
run: |
#pip install --upgrade --editable git+https://github.com/lrq3000/pyFileFixity.git#egg=pyFileFixity[test] --verbose # for cutting-edge, if we update reedsolomon's API, we will usually also update pyFileFixity's
pip install --upgrade --editable pyfilefixity[test] --pre --verbose # use latest dev release
pip install --upgrade --editable git+https://github.com/lrq3000/pyFileFixity.git#egg=pyFileFixity[test] --verbose
# pip install --upgrade --editable pyfilefixity[test] --pre --verbose # As of pip 23.1, this is not supported, --editable requires a local path or a VCS url
- name: Install Cython module
if: ${{ matrix.python-version != 'pypy-3.9' }} # ${{}} GitHub expression syntax, need to place the target python-version in single quotes (not double quotes!) so that it does not stop parsing the literal at dots, otherwise dots will truncate the string https://docs.github.com/en/actions/learn-github-actions/expressions
run: |
Expand Down

0 comments on commit b24076f

Please sign in to comment.