Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teleporation: Support Py3.11 #515

Merged
merged 4 commits into from Nov 20, 2022

Conversation

Jongy
Copy link
Contributor

@Jongy Jongy commented Nov 18, 2022

Closes: #513

Open points:

  • unlike the py38 diff with older versions (posonlyargs), the fields added in py311 play a more important role and I haven't tested yet if a function teleported from e.g 3.8 to 3.11 will behave correctly despite co_exceptiontable not initialized properly.
  • co_qualname can use co_name if missing (e.g 3.8 -> 3.11 teleportation)
  • test_teleportation.py::test_compat is broken, it works on the assumption that CodeType was broken only on 3.8, and requires a redesign to work properly on 3.11 era, I think (it currently tests 4 permutations and it will have to test 9 with 3.11)

Otherwise - all local, same-version tests are passing, so this can be safely used 3.11 <-> 3.11 I think, and also teleportations of 3.11 -> lower can be used (but not the other way around until the points I mentioned are investigated).

comrumino added a commit that referenced this pull request Nov 19, 2022
@comrumino comrumino marked this pull request as ready for review November 19, 2022 22:25
@comrumino comrumino marked this pull request as draft November 19, 2022 22:28
@comrumino comrumino marked this pull request as ready for review November 20, 2022 06:22
@comrumino
Copy link
Collaborator

Looks good enough after my commits

@comrumino comrumino merged commit defdb60 into tomerfiliba-org:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_teleportation.py fails with python3.11
2 participants