Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes #558 #559

Merged
merged 11 commits into from
Jun 24, 2024
Merged

closes #558 #559

merged 11 commits into from
Jun 24, 2024

Conversation

rlehfeld
Copy link
Contributor

This pull request fixes the 4 issues mentioned in #558

@rlehfeld rlehfeld mentioned this pull request Jun 16, 2024
Open
@comrumino comrumino self-assigned this Jun 24, 2024
@rlehfeld @comrumino
commit support for objects and classes without __class__ property
db7bd69
@rlehfeld @comrumino
create dummy commit
599b905
@rlehfeld @comrumino
undo dummy commit
c8f8a28
@rlehfeld @comrumino
do not use hasattr but instead insepct.isroutine
151d1e3
@rlehfeld @comrumino
fix race when the garbage collector jumps in the middle between the c…
ac283a9 
…heck if element is in the proxy_cache and getting the element from the cache
@rlehfeld @comrumino
revert change
808676e
@rlehfeld @comrumino
looks like None is also stored. Use temporary instance so nonexistent…
e8ae2ba 
… situation can be detected
@rlehfeld @comrumino
still does not work
20f3392
@rlehfeld @comrumino
try again proper fix. Did it actually work when looking at the result…
c2365ff 
… from the old actions?
@rlehfeld @comrumino
fix another possible race related to WeakValueDict
827dd48
@rlehfeld @comrumino
when taking ownership of stdin and stdout in PipeStream, the stdin an…
6c6e60e 
…d stdout must be replaced by devnull as on one hand the code executed could write to it but also we will close the channels and thus cause exit code failures
@comrumino
Copy link
Collaborator 

 gh pr checkout  559
 git rebase origin/master
 git push -f git@github.com:rlehfeld/rpyc.git HEAD:master

synced

@comrumino comrumino merged commit d138bcb into tomerfiliba-org:master Jun 24, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@comrumino comrumino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rlehfeld @comrumino