chore: turn on a few more mypy settings

.pre-commit-config.yaml

@@ -44,7 +44,7 @@ repos:
   rev: v1.2.5
   hooks:
   - id: pycln
-    args: [--config=pyproject.toml]
+    args: [--all]
     stages: [manual]
 
 - repo: https://github.com/pycqa/flake8
@@ -59,7 +59,7 @@ repos:
   hooks:
   - id: mypy
     files: plumbum
-    args: [--show-error-codes]
+    args: []
     additional_dependencies: [typed-ast, types-paramiko, types-setuptools]
 
 # This wants the .mo files removed

plumbum/colorlib/factories.py

@@ -1,11 +1,11 @@
 """
 Color-related factories. They produce Styles.
-
 """
 
 
 import sys
 from functools import reduce
+from typing import Any
 
 from .names import color_names, default_styles
 from .styles import ColorNotFound
@@ -108,7 +108,7 @@ def __enter__(self):
         """This will reset the color on leaving the with statement."""
         return self
 
-    def __exit__(self, _type, _value, _traceback) -> None:
+    def __exit__(self, _type: Any, _value: Any, _traceback: Any) -> None:
         """This resets a FG/BG color or all styles,
         due to different definition of RESET for the
         factories."""

plumbum/commands/processes.py

@@ -262,7 +262,8 @@ def _shutdown_bg_threads():
     global _shutting_down  # pylint: disable=global-statement
     _shutting_down = True
     # Make sure this still exists (don't throw error in atexit!)
-    if _timeout_queue:
+    # TODO: not sure why this would be "falsy", though
+    if _timeout_queue:  # type: ignore[truthy-bool]
         _timeout_queue.put((SystemExit, 0))
         # grace period
         bgthd.join(0.1)

plumbum/machines/remote.py

@@ -6,7 +6,7 @@
 from plumbum.lib import ProcInfo
 from plumbum.machines.base import BaseMachine
 from plumbum.machines.env import BaseEnv
-from plumbum.machines.local import LocalPath
+from plumbum.path.local import LocalPath
 from plumbum.path.remote import RemotePath, RemoteWorkdir, StatRes
 
 

plumbum/path/utils.py

@@ -1,7 +1,8 @@
 import os
 
-from plumbum.machines.local import LocalPath, local
+from plumbum.machines.local import local
 from plumbum.path.base import Path
+from plumbum.path.local import LocalPath
 
 
 def delete(*paths):

pyproject.toml

@@ -15,6 +15,20 @@ files = ["plumbum"]
 python_version = "3.6"
 warn_unused_configs = true
 warn_unused_ignores = true
+show_error_codes = true
+enable_error_code = ["ignore-without-code", "truthy-bool"]
+disallow_any_generics = false
+disallow_subclassing_any = false
+disallow_untyped_calls = false
+disallow_untyped_defs = false
+disallow_incomplete_defs = true
+check_untyped_defs = false
+disallow_untyped_decorators = false
+no_implicit_optional = true
+warn_redundant_casts = true
+warn_return_any = false
+no_implicit_reexport = true
+strict_equality = true
 
 
 [[tool.mypy.overrides]]
@@ -50,9 +64,6 @@ ignore = [
   "CONTRIBUTING.rst",
 ]
 
-[tool.pycln]
-all = true
-
 
 [tool.pylint]
 master.py-version = "3.6"