feat: support forcing color/nocolor (#575)

* feat: support forcing color/nocolor

* tests: ignore occasional PyPy error

* chore: remove Python 3 __div__ workaround

* fix: guard style

CHANGELOG.rst

@@ -1,3 +1,11 @@
+1.8.0
+-----
+
+* Drop Python 2.7 and 3.5 support (`#573 <https://github.com/tomerfiliba/plumbum/pull/573>`_)
+* Color: support ``NO_COLOR``/``FORCE_COLOR`` (`#575 <https://github.com/tomerfiliba/plumbum/pull/575>`_)
+
+
+
 1.7.2
 -----
 

plumbum/colorlib/styles.py

@@ -39,22 +39,26 @@
 
 def get_color_repr():
     """Gets best colors for current system."""
+    if "NO_COLOR" in os.environ:
+        return 0
+    if os.environ.get("FORCE_COLOR", "0") in {"0", "1", "2", "3", "4"}:
+        return int(os.environ["FORCE_COLOR"])
     if not sys.stdout.isatty():
-        return False
+        return 0
 
     term = os.environ.get("TERM", "")
 
     # Some terminals set TERM=xterm for compatibility
     if term.endswith("256color") or term == "xterm":
         return 3 if platform.system() == "Darwin" else 4
-    elif term.endswith("16color"):
+    if term.endswith("16color"):
         return 2
-    elif term == "screen":
+    if term == "screen":
         return 1
-    elif os.name == "nt":
+    if os.name == "nt":
         return 0
-    else:
-        return 3
+
+    return 3
 
 
 class ColorNotFound(Exception):

plumbum/machines/paramiko_machine.py

@@ -18,11 +18,9 @@
 except ImportError:
 
     class paramiko:  # type: ignore
-        def __nonzero__(self):
+        def __bool__(self):
             return False
 
-        __bool__ = __nonzero__
-
         def __getattr__(self, name):
             raise ImportError("No module named paramiko")
 
@@ -433,7 +431,7 @@ def _path_stat(self, fn):
         except OSError as e:
             if e.errno == errno.ENOENT:
                 return None
-            raise OSError(e.errno)
+            raise
         res = StatRes(
             (
                 st.st_mode,

plumbum/path/base.py

@@ -31,12 +31,10 @@ class Path(str, ABC):
     def __repr__(self):
         return f"<{self.__class__.__name__} {str(self)}>"
 
-    def __div__(self, other):
+    def __truediv__(self, other):
         """Joins two paths"""
         return self.join(other)
 
-    __truediv__ = __div__
-
     def __getitem__(self, key):
         if type(key) == str or isinstance(key, Path):
             return self / key

tests/test_remote.py

@@ -356,6 +356,7 @@ def test_session(self):
                 _, out, _ = sh.run("ls -a")
                 assert ".bashrc" in out or ".bash_profile" in out
 
+    @pytest.mark.xfail(env.PYPY, reason="PyPy sometimes fails here", strict=False)
     def test_env(self):
         with self._connect() as rem:
             with pytest.raises(ProcessExecutionError):