Fixing tests on Mac #217
Merged
Fixing tests on Mac #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of ls --bla is different, usage is lowercase, and printenv only will return one environment variable
|
@henryiii - there's now a merge conflict with this pull request, and readthedocs complains about build failures: https://readthedocs.org/projects/plumbum/builds/ . can you please have a look? |
Conflicts: plumbum/lib.py tests/test_cli.py
|
The read the docs error was an error on my part ( I'll see about adding to the changelog next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macs (at least Yosemite) run all the tests without error now, changed several checks for returned text from commands to accept the Mac answer, too.
Also moved
captured_stdout,skipIfaddition tolib.py, to better support DRY.