Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode fixes for Python 2 (and tests for Python 3) #341

Merged
merged 4 commits into from
Aug 26, 2017
Merged

Unicode fixes for Python 2 (and tests for Python 3) #341

merged 4 commits into from
Aug 26, 2017

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Aug 25, 2017

Python 2 Plumbum fails (for example, on Travis) if you have unicode in your output. This fixes that, and tests it.

It is still not supported to use a unicode path in Python 2 (and probably that limitation will remain until Python 2 dies).

@coveralls
Copy link

coveralls commented Aug 25, 2017

Coverage Status

Coverage decreased (-0.04%) to 81.073% when pulling 4a0703d on uni into a39e7ba on master.

@coveralls
Copy link

coveralls commented Aug 25, 2017

Coverage Status

Coverage decreased (-0.04%) to 81.073% when pulling dca6d3b on uni into a39e7ba on master.

@coveralls
Copy link

coveralls commented Aug 25, 2017

Coverage Status

Coverage decreased (-0.06%) to 81.051% when pulling db6ccb5 on uni into a39e7ba on master.

@henryiii henryiii merged commit a6dec8b into master Aug 26, 2017
@henryiii henryiii deleted the uni branch August 26, 2017 06:28
@coveralls
Copy link

coveralls commented Aug 26, 2017

Coverage Status

Coverage decreased (-0.06%) to 81.051% when pulling 1d451b8 on uni into a39e7ba on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants