Support PuttyMachine file upload and download using non-default port #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #369. If a PuttyMachine instance is created to an ssh server that is running on the non-default port, then the upload and download methods fail, because
pscp
is still using the default port instead of the actual port.I have added some tests. The tests verify:
__init__
of SshMachine with the correct parametersPuttyMachine.__str__
has the expected message.The tests can run on any system even without Putty installed. One of the test fails on PyPy, but it is marked with
@xfail_on_pypy
. It fails on PyPy because the feature ofpytest-mock
used in that test does not work on PyPy.