Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documented behavoir for override, drop overwrite #462

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Sep 9, 2019

Fixes #245. Please comment on whether this is a good plan, or provide suggestions.

Same behavior as current Plumbum if no arguments supplied.

@coveralls
Copy link

coveralls commented Sep 9, 2019

Coverage Status

Coverage decreased (-0.02%) to 82.498% when pulling eeb07bb on henryiii-override into 456d2c3 on master.

@AndydeCleyre
Copy link
Contributor

Here there is a mismatch in base.py:

def copy(self, dst, override=False):

Will silently fail to copy if override is None (the default).

@henryiii henryiii merged commit efa082c into master Sep 18, 2019
@henryiii henryiii deleted the henryiii-override branch September 18, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override
3 participants