Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli set validator #467

Merged
merged 2 commits into from
Sep 22, 2019
Merged

Fix cli set validator #467

merged 2 commits into from
Sep 22, 2019

Conversation

koreno
Copy link
Collaborator

@koreno koreno commented Sep 21, 2019

Fix for bug mentioned in #452 (comment)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 82.416% when pulling d156bb6 on fix-cli-Set-validator into efa082c on master.

henryiii
henryiii approved these changes Sep 22, 2019
View reviewed changes
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though could we get a similar test for non-CSV sets? That's what the bug broke, I believe, so I'm assuming it's missing in the current code. I (or you) could add it in a separate PR, though, so as not to hold up this one.

@henryiii henryiii merged commit 99e0cfa into master Sep 22, 2019
@henryiii henryiii deleted the fix-cli-Set-validator branch September 22, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@koreno @coveralls @henryiii