Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small touchup for readme #469

Merged
merged 3 commits into from Sep 27, 2019
Merged

Small touchup for readme #469

merged 3 commits into from Sep 27, 2019

Conversation

henryiii
Copy link
Collaborator

Fixes #463. Does this look like a good idea to everyone?

@coveralls
Copy link

coveralls commented Sep 23, 2019

Coverage Status

Coverage increased (+0.03%) to 82.43% when pulling c15d707 on henryiii-readme into 86363a1 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 82.346% when pulling 00cd55b on henryiii-readme into 86363a1 on master.

@koreno
Copy link
Collaborator

koreno commented Sep 24, 2019

what about the new local.cmd.ls form? I think it's a bit more pythonic than the from plumbum.cmd import ls...

@henryiii
Copy link
Collaborator Author

We should at least mention it, though importing things from packages is quite pythonic - I would say the local.cmd.ls form is handier, since you don't need multiple imports, but not more pythonic. It also downgrades more elegantly into the local[] form.

@henryiii
Copy link
Collaborator Author

How about that? Or we can change further if needed.

@koreno
Copy link
Collaborator

koreno commented Sep 24, 2019

though importing things from packages is quite pythonic

Yes, when that package actually exists... a magical import is much less common than a __getattr__, hence my "less pythonic" argument.

It also downgrades more elegantly into the local[] form.
Indeed, and also to the RemoteMachine case:

from plumbum import SshMachine
remote = SshMachine(...)
remote.cmd.ls()

the import syntax doesn't help here...

@henryiii
Copy link
Collaborator Author

Okay, you've convinced me with the remote machine. I've made this a bit more obvious and reduced the magic import to a side note.

@koreno
Copy link
Collaborator

koreno commented Sep 27, 2019 via email

@henryiii henryiii merged commit d1392f8 into master Sep 27, 2019
@henryiii henryiii deleted the henryiii-readme branch September 27, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First two code lines on the front page
3 participants