Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom typeface #22

Closed
wants to merge 2 commits into from
Closed

added custom typeface #22

wants to merge 2 commits into from

Conversation

iGio90
Copy link

@iGio90 iGio90 commented Mar 22, 2018

No description provided.

@iGio90
Copy link
Author

iGio90 commented Mar 22, 2018

Sorry for no desc/comment... just phew lines of code for personal usage :)

hossain-khan added a commit to hossain-khan/tooltips that referenced this pull request Mar 30, 2018
Allow text appearance customization with README updated.

This fixes tomergoldst#22
@hossain-khan
Copy link
Contributor

hey @iGio90 I didn't notice this PR before, but I created a PR that covers this use case.
Feel free to review #23

@tomergoldst
Copy link
Owner

Hi @iGio90 ,
Thank you for contributing this library.
I have looked at your PR and @amardeshbd PR and since the latter one is more comprehensive and include the same changes you did we will close your PR and accept the other.
If you will have further improvements in the future we will be happy to hear from you

@tomergoldst tomergoldst closed this Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants