Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll site #65

Merged
merged 10 commits into from
Oct 19, 2018
Merged

Jekyll site #65

merged 10 commits into from
Oct 19, 2018

Conversation

benhylau
Copy link
Member

Completes #63 by building and pushing a Jekyll site on tag.

@benhylau
Copy link
Member Author

Changes archive directory structure to be more like #41 (per module) and ported theme from Mozilla's as suggested by @patcon #38 (comment).

@benhylau
Copy link
Member Author

New site 🎆 https://tomeshnet.github.io/p2p-internet-workshop/

@benhylau
Copy link
Member Author

If there are no objections I am just going to merge this in a couple days. There is some text change in the README, and a whole website modified from Moz's as base, changing structure of our course asset packaging. Quite a lot in this PR.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dcwalk dcwalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not use baseurl but the relateive or aboslute path instead?? My sense is facilitators and others will still arrive at the README on GH and want to click on links.

@dcwalk
Copy link
Contributor

dcwalk commented Oct 2, 2018

Also @benhylau -- totally fine to remove the course design stuff from readme, but I think it should be kept in the repo. In part to revisit/reflect on in future design iterations.

Maybe a course-design folder?
Or a planning folder and could move some stuff from general there? Also, general is kind of a weird name

@benhylau
Copy link
Member Author

benhylau commented Oct 2, 2018

Yea I had to choose between breaking README rendering on GitHub or hardcoding a path, but I suppose the latter is not that bad since the file originate from outside the site folder, and your point about people arriving to GitHub is very true. I will change to hardcode.

The only course design lines removed were:

  • Create syllabus with sufficient flexibility so it can be adapted to Toronto Libraries in other areas and other settings
  • With a community network project as basis, establish regular hack nights at the Toronto Libraries' Innovation Hubs
  • Engage students and equip them with necessary knowledge to continue involvement in local mesh community efforts
  • Publish this as open-source syllabus that other communities can adopt to kick-start a mesh community

I think the first two are specific to a particular facilitation and no longer fit in the repo. If those are Toronto goals they should be tracked in some facilitation planning board like other facilitation efforts?

Perhaps we can integrate latter two points somewhere on README?

@benhylau
Copy link
Member Author

Addressed comments and added new issue to add back course design lines. Merging since this contains significant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants