-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jekyll site #65
Jekyll site #65
Conversation
Changes archive directory structure to be more like #41 (per module) and ported theme from Mozilla's as suggested by @patcon #38 (comment). |
If there are no objections I am just going to merge this in a couple days. There is some text change in the README, and a whole website modified from Moz's as base, changing structure of our course asset packaging. Quite a lot in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not use baseurl
but the relateive or aboslute path instead?? My sense is facilitators and others will still arrive at the README on GH and want to click on links.
Also @benhylau -- totally fine to remove the course design stuff from readme, but I think it should be kept in the repo. In part to revisit/reflect on in future design iterations. Maybe a |
Yea I had to choose between breaking README rendering on GitHub or hardcoding a path, but I suppose the latter is not that bad since the file originate from outside the The only course design lines removed were:
I think the first two are specific to a particular facilitation and no longer fit in the repo. If those are Toronto goals they should be tracked in some facilitation planning board like other facilitation efforts? Perhaps we can integrate latter two points somewhere on README? |
Addressed comments and added new issue to add back course design lines. Merging since this contains significant changes. |
Completes #63 by building and pushing a Jekyll site on tag.