Hostap update for Orange Pi #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhylau
requested changes
Oct 26, 2017
scripts/hostapd/install
Outdated
| @@ -9,6 +9,16 @@ if ! [ "$(which hostapd)" ] || ! [ "$(which dnsmasq)" ]; then | |||
| sudo apt-get install hostapd dnsmasq radvd -y | |||
| fi | |||
|
|
|||
| #if ! [ "$(which dnsmasq)" ]; then | |||
There was a problem hiding this comment.
Why? Old version on Orange Pi's?
benhylau
requested changes
Oct 29, 2017
scripts/hostapd/install
Outdated
| if ! [ "$(which hostapd)" ] || ! [ "$(which dnsmasq)" ]; then | ||
| sudo apt-get install hostapd dnsmasq radvd -y | ||
| fi | ||
| sudo apt-get install hostapd dnsmasq radvd dnsmasq iptables -y |
There was a problem hiding this comment.
# Install packages to run IEEE 802.11 Access Point and dnsmasq is doubled
scripts/hostapd/install
Outdated
| sudo echo "" | sudo tee --append /etc/dhcpcd.conf > /dev/null | ||
| sudo echo "denyinterfaces wlan0" | sudo tee --append /etc/dhcpcd.conf > /dev/null | ||
|
|
||
|
|
There was a problem hiding this comment.
Please do not have random newlines everywhere.
scripts/install2
Outdated
| @@ -11,13 +11,18 @@ BOARD_REVISION="?" | |||
| CJDNS_BUILD_CMD="sudo Seccomp_NO=1 NO_NEON=1 ./do" | |||
| BOARD_HARDWARE=$(cat /proc/cpuinfo | grep Hardware | awk '{print $3}' | head -n 1) | |||
|
|
|||
| ALLOW_HOSTAP=false #Flag for prompt of hostap | |||
There was a problem hiding this comment.
SUPPORT_HOSTAP? The comment for the flag should be whether the board supports hostapd, the prompt is just the effect of the flag being true.
scripts/install2
Outdated
| @@ -61,6 +67,9 @@ if [[ $BOARD_FAMILY == "Orange Pi" ]]; then | |||
| wget http://apt.armbian.com/pool/main/l/linux-4.10.0-sun8i/linux-image-dev-sun8i_5.26_armhf.deb | |||
| sudo dpkg -i linux-image-dev-sun8i_5.26_armhf.deb | |||
| rm -rf linux-image-dev-sun8i_5.26_armhf.deb | |||
| ALLOW_HOSTAP=true #downgrading kernel, allow hostapd | |||
There was a problem hiding this comment.
The downgrade is still needed here?
scripts/install2
Outdated
| @@ -61,6 +67,9 @@ if [[ $BOARD_FAMILY == "Orange Pi" ]]; then | |||
| wget http://apt.armbian.com/pool/main/l/linux-4.10.0-sun8i/linux-image-dev-sun8i_5.26_armhf.deb | |||
| sudo dpkg -i linux-image-dev-sun8i_5.26_armhf.deb | |||
| rm -rf linux-image-dev-sun8i_5.26_armhf.deb | |||
| ALLOW_HOSTAP=true #downgrading kernel, allow hostapd | |||
| else | |||
| ALLOW_HOSTAP=false #Zero is not downgraded from broken kernel, dont allow hostap | |||
added 2 commits
October 29, 2017 13:31
benhylau
approved these changes
Oct 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have to finish testing it still but i think that some of the change here will help with stretch as well