Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map of active and prospective nodes to site #151

Closed
4 tasks done
dcwalk opened this issue Jul 22, 2017 · 8 comments
Closed
4 tasks done

Add map of active and prospective nodes to site #151

dcwalk opened this issue Jul 22, 2017 · 8 comments

Comments

@dcwalk
Copy link
Contributor

dcwalk commented Jul 22, 2017

Working from @darkdrgn2k's map codebase (currently accessible at http://map.tomesh.net):
https://github.com/darkdrgn2k/TOMeshNodeMap

We want to have:

  • Finalize Schema
  • Commit Initial Node List
  • new page for map (available at /map)
  • add Map to global navigation
@dcwalk dcwalk mentioned this issue Jul 22, 2017
4 tasks
@dcwalk
Copy link
Contributor Author

dcwalk commented Jul 22, 2017

Other notes about the map:

  • Using google api
  • node data coming from a json (node-list GitHub)
  • submit from the map interface (using a form! backend: submit PR to node list)

For stage 1 we'll not spend time optimizing for monitoring needs.

Stage 2:

  • Hooking in with monitoring functionality
  • "status" in a broader sense:
    • online?
    • last seen
    • node peers

@darkdrgn2k
Copy link
Contributor

Submit PR request may be harder via api the first thought
https://developer.github.com/v3/pulls/#create-a-pull-request
Seems you need to first commit the change to an GitHub branch tree before you do a pull request

So the way i see it to hook it from a form the form would need to

  1. Create a branch
  2. Update the json in that branch
  3. commit that branch
  4. create a commit request against the branch

@darkdrgn2k
Copy link
Contributor

darkdrgn2k commented Jul 23, 2017

Work is being done to integrate the existing code base into the tomesh site

Working tree for the map is located at https://github.com/darkdrgn2k/tomesh.net/tree/Map

  • Added map as /map
  • Added to global nav

Just working some loose ends, formatting
Current path for nodes is https://github.com/darkdrgn2k/node-list/master/nodeList.json

@darkdrgn2k darkdrgn2k mentioned this issue Jul 23, 2017
Merged
@dcwalk
Copy link
Contributor Author

dcwalk commented Jul 24, 2017

Nice!

Just to transfer over @garrying 's comment from our chat -- this work has been merged into the Dev branch

@darkdrgn2k
Copy link
Contributor

@dcwalk @Shrinks99 @garrying Thoughts on pushing nodeList.json into node-list so it no longer references my git hub?

PR for initial Node List at tomeshnet/node-list#6

@dcwalk
Copy link
Contributor Author

dcwalk commented Aug 15, 2017

Agree @darkdrgn2k! I left my comments there :)

@darkdrgn2k
Copy link
Contributor

darkdrgn2k commented Aug 26, 2017

PR Committed tomeshnet/node-list#6 with official node list

Now waiting on final review/add of

  • Updated Look/Feel of map with @Shrinks99
  • Align Map to new Schema
  • Decision on Add a node (Since PR are trickier all reference of "add node" currently removed and replaced with "here is the json of your node for your reference"

@dcwalk
Copy link
Contributor Author

dcwalk commented Sep 6, 2017

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants