Initial Node List #6

darkdrgn2k · 2017-08-13T17:39:24Z

Initial node list for use on the tomesh.net site tomeshnet/tomesh.net#151

Corrected formatting

benhylau · 2017-08-14T01:18:56Z

What is the source of this list?

darkdrgn2k · 2017-08-14T03:41:08Z

@benhylau The existing temporary map (map.tomesh.net) which was original primary derived from @Pedro-on-a-bike and a handfull of other manual nodes. Its the same list that is currently powering tomesh.net dev branch's map.

benhylau · 2017-08-14T15:04:40Z

nodeList.json

+      "cardinalDirection":"South",
+      "floor":"1",
+      "meshHardware":"Unknown",
+      "IPV6Address":"h.groundupworks.com",


Should we require this field be address only? fcaa:5785:a537:90db:6513:bba9:87a0:12a7

Good question, what happens when the addresses changes though?

Honesty the schema has not been finalized yet i just wanted to start somewhere.

A node having a copy of this list should be able to reach every node without internet connection, but if some of the node addresses are domain names we would need DNS, which currently does not exist in-mesh. I am okay merging as is, since it's trivial to fix this later.

benhylau · 2017-08-14T15:06:23Z

nodeList.json

+      "latitude":43.63518200000000,
+      "longitude":-79.40201470000000,
+      "onlineStatus":"Online",
+      "cardinalDirection":"South",


Should these be [ N E S W NE NW SE SW ] for better resolution?

Hmm, actually I think those exist already, nevermind: #5

dcwalk · 2017-08-15T13:06:21Z

Our initial schema draft elsewhere #2 doesn't have all these field specified, (and addresses your questions @benhylau)

I'm in favour of merging this in as is, because as @darkdrgn2k says it is currently powering the map but doesn't live in a tomesh repo 😨 . Then we should get that schema reviewed and merged in (#2 should be good to go), and update this list to reflect that.

garrying · 2017-08-15T18:14:04Z

nodeList.json

@@ -0,0 +1,900 @@
+[


Should this be an object instead of an array? Referencing the schema

The code i got from Pedro seems to reference it as an array, so the site is coded to look for an array. I would have to go back and change the code to treat it as an object.

I ran the Schema and the Node List via http://www.jsonschemavalidator.net/ and it checks out. In fact Javascript and above site errors out parsing { instrad of [

We'd need to add keys to the node objects for to it validate. I'd be okay with keeping it as is for now.

These comments have been moved to #8 for tracking!

garrying · 2017-08-15T20:57:39Z

nodeList.json

+      "onlineStatus":"Offline",
+      "cardinalDirection":"North West",
+      "floor":23,
+      "meshHardware":"None",


For meshHardware and IPV6Addres: We alternate between None and Unknown. I wonder if it would be better to have them be empty.

currently there is a difference between the two

None means there simply is non
Unknown means that it exists, we just don't know what it is

For example there IS hardware in willow-dale mesh but there is NO hardware in most of the possible spots.

Do we need "None" then? I'm assuming that is the case for proposed? (The field isn't required IIRC and isn't in the initial schema)

Changed structure from ARRAY to OBJECT

Removed some custom fields

dcwalk · 2017-08-15T21:46:22Z

nodeList.json

-      "lastPing":"-1",
-      "rtt":"0"
+      "status":"active",
+      "dateAdded":"2017-18-15T00:00:00.0Z"


Should this be 2017-08-15?

dcwalk · 2017-08-15T21:47:24Z

nodeList.json

+      "onlineStatus":"Offline",
+      "cardinalDirection":"North West",
+      "floor":23,
+      "meshHardware":"None",


Do we need "None" then? I'm assuming that is the case for proposed? (The field isn't required IIRC and isn't in the initial schema)

dcwalk · 2017-08-15T21:48:00Z

nodeList.json

-      "lastPing":"-1",
-      "rtt":"0"
+      "status":"active",
+      "dateAdded":"2017-18-15T00:00:00.0Z"
   },
   {
      "name":"Willowdale Mesh Node",


I wasn't aware that this had been added prior to confirming. Can we identify what nodes in the list are like that?
I'd prefer they not be added in unless confirmed/added by the individual

Already reached out to confirm, removed until then.

Update ipv6 Address and hardware

dcwalk · 2017-08-15T22:11:25Z

nodeList.json

+      "cardinalDirection":"Omni",
+      "floor":"0",
+      "status":"active",
+      "dateAdded":"2017-15-18T00:00:00.0Z"


I think the new commit still carried forward an issue with the date
2017-15-18T00:00:00.0Z
should be 2017-08-15T00:00:00.0Z

dcwalk · 2017-08-16T21:51:04Z

It looks like we are almost ready to merge in this first pass?

My one thought is we should specify a license for the data, would be nice to add in on this PR if possible before it lives in the repo!

dcwalk · 2017-08-22T03:12:05Z

Great, glad we are all happy with getting something in now! I'm gonna merge 🎉 @darkdrgn2k for pushing this through. Lets address Travis CI, next iteration of spec etc... down the road, but now we have everything to host the proposed first version of the map.

darkdrgn2k added 2 commits July 22, 2017 17:16

Node List

1238cea

Added few missing nodes

32cc17b

Corrected formatting

darkdrgn2k mentioned this pull request Aug 13, 2017

Add map of active and prospective nodes to site tomeshnet/tomesh.net#151

Closed

4 tasks

darkdrgn2k requested review from garrying, benhylau and dcwalk August 14, 2017 03:41

benhylau reviewed Aug 14, 2017

View reviewed changes

dcwalk approved these changes Aug 15, 2017

View reviewed changes

garrying reviewed Aug 15, 2017

View reviewed changes

darkdrgn2k added 3 commits August 15, 2017 17:08

Corrected spelling of IPV6Addres (missing s)

ad9e059

Changed structure from ARRAY to OBJECT

reverted back to array

ab661cd

Added status and dateAdded fields

84fa430

Removed some custom fields

dcwalk reviewed Aug 15, 2017

View reviewed changes

darkdrgn2k added 3 commits August 15, 2017 17:55

Corrected time format

160a9e4

Update ipv6 Address and hardware

Removed unknown and none Mesh Hardware and IPV6Address

d5dfa6b

Removed IPv6 unknown addressed missed in last round

835f3ca

dcwalk reviewed Aug 15, 2017

View reviewed changes

Corrected Time and removed pending nodes

6478215

dcwalk mentioned this pull request Aug 16, 2017

Switch to json object vs. array in node list #8

Closed

darkdrgn2k added 2 commits August 16, 2017 18:42

Added new entry for a willowdale mesh node.

da354b0

Updated Direction of Willow Dale Mesh

51dee39

benhylau approved these changes Aug 17, 2017

View reviewed changes

Removed Contact field

f7fb62e

dcwalk merged commit 4836f3c into tomeshnet:master Aug 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial Node List #6

Initial Node List #6

darkdrgn2k commented Aug 13, 2017

benhylau commented Aug 14, 2017

darkdrgn2k commented Aug 14, 2017

benhylau Aug 14, 2017

darkdrgn2k Aug 14, 2017

benhylau Aug 17, 2017

benhylau Aug 14, 2017

benhylau Aug 14, 2017

dcwalk commented Aug 15, 2017 •

edited

garrying Aug 15, 2017

darkdrgn2k Aug 15, 2017

darkdrgn2k Aug 15, 2017

garrying Aug 15, 2017

dcwalk Aug 16, 2017

garrying Aug 15, 2017

darkdrgn2k Aug 15, 2017

dcwalk Aug 15, 2017

dcwalk Aug 15, 2017

dcwalk Aug 15, 2017

dcwalk Aug 15, 2017

darkdrgn2k Aug 15, 2017

dcwalk Aug 15, 2017

dcwalk commented Aug 16, 2017

dcwalk commented Aug 22, 2017

Initial Node List #6

Initial Node List #6

Conversation

darkdrgn2k commented Aug 13, 2017

benhylau commented Aug 14, 2017

darkdrgn2k commented Aug 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dcwalk commented Aug 15, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dcwalk commented Aug 16, 2017

dcwalk commented Aug 22, 2017

dcwalk commented Aug 15, 2017 •

edited