TAG-4085 - tribe tooltip add position #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexmaster
suggested changes
Dec 12, 2017
| }); | ||
| } | ||
| else if (tribeTooltip.position === 'bottom') | ||
| if (positions[0] === 'top' || positions[0] === 'bottom') |
There was a problem hiding this comment.
Please replace positions[0] === 'top' with positions.indexOf('top') > -1 and other compatisons too...
There was a problem hiding this comment.
We do not expect person to know in which order everything should be, also you can do same thing in strings (array is good too, just use indexOf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to the tribe-tooltip, new type of positioning, passed by the position attribute
Now we allow, for top and bottom: left, right and middle
examples:
top left, top middle, top right
Note: it was only implemented for top and bottom