Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign version when building Docker image and introduce system endpoint #1219

Merged
merged 2 commits into from Aug 18, 2020

Conversation

tomkerkhove
Copy link
Owner

@tomkerkhove tomkerkhove commented Aug 14, 2020

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

  • Provide unit tests
  • Run integration tests in scraper CI
  • Run integration tests in scraper release
  • Run integration tests in resource discovery CI
  • Test scraper CI
  • Test scraper release
  • Test resource discovery CI
  • Verify Scraper Docker image (Linux)
  • Verify Scraper Docker image (Windows)
  • Verify Resource Discovery Docker image (Linux)
  • Verify Resource Discovery Docker image (Windows)

Fixes #1017
Fixes #1208

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 14, 2020
@tomkerkhove tomkerkhove changed the title 🚧 Assign version when building Docker image 🚧 Assign version when building Docker image and introduce system endpoint Aug 14, 2020
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Repository owner deleted a comment from promitor-bot Aug 17, 2020
Repository owner deleted a comment from promitor-bot Aug 17, 2020
Repository owner deleted a comment from promitor-bot Aug 17, 2020
Repository owner deleted a comment from promitor-bot Aug 17, 2020
Repository owner deleted a comment from promitor-bot Aug 17, 2020
Repository owner deleted a comment from promitor-bot Aug 17, 2020
Repository owner deleted a comment from promitor-bot Aug 17, 2020
Repository owner deleted a comment from promitor-bot Aug 17, 2020
Repository owner deleted a comment from promitor-bot Aug 17, 2020
Repository owner deleted a comment from promitor-bot Aug 17, 2020
@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1219-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1219-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1219-linux

You can find a CI version of our Helm chart on hub.helm.sh

@tomkerkhove tomkerkhove changed the title 🚧 Assign version when building Docker image and introduce system endpoint Assign version when building Docker image and introduce system endpoint Aug 18, 2020
@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1219-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1219-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1219-linux

You can find a CI version of our Helm chart on hub.helm.sh

@tomkerkhove tomkerkhove merged commit 9e324a3 into master Aug 18, 2020
@tomkerkhove tomkerkhove deleted the stamp-version branch August 18, 2020 14:36
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✨ Merged Pull Request has been merged successfully 🔍 Ready for Review Pull Request is not reviewed yet labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide system API endpoint Assign version when building Docker image
2 participants