Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Add group for Prometheus.Client in Renovate config #2112

Merged
merged 1 commit into from Aug 26, 2022
Merged

chore(deps): Add group for Prometheus.Client in Renovate config #2112

merged 1 commit into from Aug 26, 2022

Conversation

phnx47
Copy link
Contributor

@phnx47 phnx47 commented Aug 26, 2022

Combine update all Prometheus.Client packages into one PR

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 26, 2022
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

tomkerkhove
tomkerkhove approved these changes Aug 26, 2022
View reviewed changes
Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Aug 26, 2022
@tomkerkhove tomkerkhove changed the title Renovate: Add group for Prometheus.Client chore(deps): Add group for Prometheus.Client in Renovate config Aug 26, 2022
@tomkerkhove
Copy link
Owner

tomkerkhove commented Aug 26, 2022 •
edited

I still need to tackle #1772 though. Are you willing to pick this up as well @phnx47? This would be a major help!

@phnx47
Copy link
Contributor Author

phnx47 commented Aug 26, 2022 •
edited

@tomkerkhove Yes, I can find time next month.

@tomkerkhove
Copy link
Owner

Thank you!

@tomkerkhove tomkerkhove merged commit 8aca709 into tomkerkhove:master Aug 26, 2022
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Aug 26, 2022
@phnx47 phnx47 deleted the group-prom-client branch August 26, 2022 13:04
@tomkerkhove
Copy link
Owner

Did you consider PRing a preset in to Renovate?

https://github.com/renovatebot/renovate/tree/main/lib/config/presets/internal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phnx47 @CLAassistant @tomkerkhove