Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(resource-discovery): Provide unit tests for AzureResourceGroupsDiscoveryBackgroundJob #2153

Merged
merged 3 commits into from Oct 14, 2022
Merged

test(resource-discovery): Provide unit tests for AzureResourceGroupsDiscoveryBackgroundJob #2153

merged 3 commits into from Oct 14, 2022

Conversation

MaurizioPz
Copy link
Contributor

Fixes #2052 by providing unit tests for AzureResourceGroupsDiscoveryBackgroundJob

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 11, 2022
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

tomkerkhove
tomkerkhove reviewed Oct 12, 2022
View reviewed changes
Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Would you mind checking the code quality check in the CI please?

...omitor.Tests.Unit/Agents/ResourceDiscovery/AzureResourceGroupsDiscoveryBackgroundJobTests.cs Show resolved Hide resolved
...omitor.Tests.Unit/Agents/ResourceDiscovery/AzureResourceGroupsDiscoveryBackgroundJobTests.cs Show resolved Hide resolved
@tomkerkhove tomkerkhove changed the title Provide unit tests for AzureResourceGroupsDiscoveryBackgroundJob #2052 test(resource-discovery): Provide unit tests for AzureResourceGroupsDiscoveryBackgroundJob Oct 14, 2022
tomkerkhove
tomkerkhove approved these changes Oct 14, 2022
View reviewed changes
Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would you mind signing the CLA and fixing the failing pipeline please?

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 14, 2022
@MaurizioPz
Copy link
Contributor Author

I signed the CLA, but I'm sorry I don't understand how to fix the pipeline, I see two kinds of errors
image
(this is repeated twice)
and this
image

To me they don't look related to the stuff I wrote, can you provide me some guidance on how to proceed? Are these tests flaky?

Thanks

@tomkerkhove
Copy link
Owner

Seems legit and will check outside of this PR seperately, merging.

Thanks!

@tomkerkhove tomkerkhove merged commit edf937a into tomkerkhove:master Oct 14, 2022
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide unit tests for AzureResourceGroupsDiscoveryBackgroundJob
3 participants
@MaurizioPz @CLAassistant @tomkerkhove