This repository has been archived by the owner on Sep 24, 2022. It is now read-only.
Support for dotted table spans #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In toml you can declare maps via {} and via [name].
We can't obtain spans for [] maps but at least we
can emit fake spans to make SpannedValue work.
We also add a regression test.
est31
force-pushed
the
dotted_table_spans
branch
from
5ecc863
to
e9ef0e8
Compare
Closed
est31
force-pushed
the
dotted_table_spans
branch
from
85a0feb
to
4ef649b
Compare
|
Looks reasonable to me, sorry for the delay in getting to this. Thanks though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides "support" for dotted table spans by setting them to 0. While special cases could get special case logic, in the general case toml allows for dotted tables without well defined spans.
In this document, the span for the
dependenciestable is for example not well-defined:The package table for example does have a well-defined span and thus could be special-cased.