feat: Publicly expose DateTime
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This let's us test more cases we were already handling correctly. Downside is that we are exposing `chrono` in the API. I think we should flatten `DateTime` into `Value` but I want to defer that conversation, rather than have it block all of this moving forward. Fixes toml-rs#113
I think this was the reason why it wasn't exposed. |
There are several API issues we'll have to resolve before the next release (I named another in the PR description). Can we instead open a general issue for what the API should look like and bundle all of those together, so these existing branches can continue moving forward? |
|
Sure, sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This let's us test more cases we were already handling correctly.
Downside is that we are exposing
chronoin the API.I think we should flatten
DateTimeintoValuebut I want to deferthat conversation, rather than have it block all of this moving forward.
Fixes #113