-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making the global search functional #144
Making the global search functional #144
Conversation
@nfoert the button click events of ButtonsEntry don't have to be done like that, instead just pass in the tuples of format Also, the layout error was caused by the |
Thanks for the changes @billyeatcookies. The click events for |
Hi @billyeatcookies, I just got the replace functionality to work. I'm not sure we need to implement match case replace though. The replace works by looking at the results of the search and just replacing what was found when searching with what you put in the replace text box. I don't really see how match case replace would be helpful when you could just do a match case search, unless I'm not understanding it correctly. |
@nfoert the preserve case option is not that important actually, the main idea was to fully capitalize the replacing word if the found word is fully capitalized. second case would be first letter capped words, those can be replaced as first letter capped with the preserve case option. So we can ignore that part :) Also I just changed some docstring stylings, etc xd |
I'll move this to a new separate issue for now, we can resolve it later! |
Re: Making the global search functional (#144)
Sounds good, thanks @billyeatcookies! |
thanks alot for the awesome contribution! ❤ |
Fixes #130