Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the global search functional #144

Conversation

nfoert
Copy link

@nfoert nfoert commented Oct 16, 2023

Fixes #130

  • Search
    • Case Sensitive
    • Case Insensitive
    • Match Word
    • Regex
  • Replace
    • Replace all
  • Fix layout

@tomlin7 tomlin7 added the hacktoberfest-accepted Hacktoberfest accepted pr label Oct 16, 2023
@tomlin7
Copy link
Owner

tomlin7 commented Oct 16, 2023

@nfoert the button click events of ButtonsEntry don't have to be done like that, instead just pass in the tuples of format (icon_name, callback). Just for convenience and to keep the code clean xd

Also, the layout error was caused by the container used by search-replace bars set to expand=True

image

@nfoert
Copy link
Author

nfoert commented Oct 17, 2023

Thanks for the changes @billyeatcookies. The click events for ButtonsEntry makes sense, I haven't had a ton of experience with tkinter.

@nfoert
Copy link
Author

nfoert commented Oct 22, 2023

Hi @billyeatcookies, I just got the replace functionality to work. I'm not sure we need to implement match case replace though. The replace works by looking at the results of the search and just replacing what was found when searching with what you put in the replace text box. I don't really see how match case replace would be helpful when you could just do a match case search, unless I'm not understanding it correctly.
Thanks.

@tomlin7
Copy link
Owner

tomlin7 commented Oct 22, 2023

@nfoert the preserve case option is not that important actually, the main idea was to fully capitalize the replacing word if the found word is fully capitalized. second case would be first letter capped words, those can be replaced as first letter capped with the preserve case option. So we can ignore that part :)

Also I just changed some docstring stylings, etc xd

@tomlin7 tomlin7 marked this pull request as ready for review October 22, 2023 18:39
@tomlin7
Copy link
Owner

tomlin7 commented Oct 22, 2023

  • Scrolling seems to only happen sometimes (line 50 in results.py)

I'll move this to a new separate issue for now, we can resolve it later!

@tomlin7 tomlin7 merged commit 3671513 into tomlin7:130-making-the-global-search-functional Oct 22, 2023
tomlin7 added a commit that referenced this pull request Oct 22, 2023
Re: Making the global search functional (#144)
@nfoert
Copy link
Author

nfoert commented Oct 23, 2023

Sounds good, thanks @billyeatcookies!

@tomlin7
Copy link
Owner

tomlin7 commented Oct 23, 2023

thanks alot for the awesome contribution! ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest accepted pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants