fix: Window now closes when 'x' is clicked #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vyshnav-vinod thanks for opening a pr on this! apparently the window is closable with the window close button currently on windows, but technically the problem is existing. Unsure of what is causing the behavior difference. |
tomlin7
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 30a251c has made the biscuit window to not close when 'x' is clicked. This is probably due to the "WM_DELETE_WINDOW" protocol only calling the on_close_app function, which does not
destroy()the tkinter window.I checked the previous commit c9dd044 and this does close the window, so i guess the addition of the "WM_DELETE_WINDOW" protocol might have introduced the bug