Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix PRs being displayed with issues #309

Merged
merged 3 commits into from
May 14, 2024
Merged

fix: Fix PRs being displayed with issues #309

merged 3 commits into from
May 14, 2024

Conversation

vyshnav-vinod
Copy link
Contributor

Note: GitHub's REST API considers every pull request an issue, but not every issue is a pull request. For this reason, "Issues" endpoints may return both issues and pull requests in the response.

In the API docs, it shows that the PRs also get included in the issues. So biscuit was also showing PRs with the issues. This PR should fix that.

tomlin7
tomlin7 approved these changes May 14, 2024
View reviewed changes
Copy link
Owner

@tomlin7 tomlin7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good fix, the bug went unnoticed :)

also apparently instead of making it O(2n) we can just use an extra condition below.

@tomlin7 tomlin7 merged commit ae804a2 into tomlin7:main May 14, 2024
5 of 6 checks passed
@vyshnav-vinod vyshnav-vinod deleted the fix/github branch May 14, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlin7 tomlin7 tomlin7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vyshnav-vinod @tomlin7