Removes already-canceled token check.

used to cover a rare use case, therefore the perf benefits were minimal.
tommasobertoni · Jan 24, 2021 · 32cec0c · 32cec0c
1 parent 2a2f858
commit 32cec0c
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/src/NScatterGather/Aggregator.cs b/src/NScatterGather/Aggregator.cs
@@ -56,13 +56,10 @@ public Aggregator(RecipientsCollection collection)
                 .Select(runner => runner.Start())
                 .ToArray();
 
-            if (cancellationToken.IsCancellationRequested)
-                return runners;
-
             var allTasksCompleted = Task.WhenAll(tasks);
 
-            using (var cancellation = new CancellationTokenTaskSource<object?[]>(cancellationToken))
-                await Task.WhenAny(allTasksCompleted, cancellation.Task).ConfigureAwait(false);
+            using var cancellation = new CancellationTokenTaskSource<object?[]>(cancellationToken);
+            await Task.WhenAny(allTasksCompleted, cancellation.Task).ConfigureAwait(false);
 
             if (cancellationToken.IsCancellationRequested)
                 await WaitForLatecomers(runners).ConfigureAwait(false);
@@ -103,13 +100,10 @@ public Aggregator(RecipientsCollection collection)
                 .Select(runner => runner.Start())
                 .ToArray();
 
-            if (cancellationToken.IsCancellationRequested)
-                return runners;
-
             var allTasksCompleted = Task.WhenAll(tasks);
 
-            using (var cancellation = new CancellationTokenTaskSource<TResponse[]>(cancellationToken))
-                await Task.WhenAny(allTasksCompleted, cancellation.Task).ConfigureAwait(false);
+            using var cancellation = new CancellationTokenTaskSource<TResponse[]>(cancellationToken);
+            await Task.WhenAny(allTasksCompleted, cancellation.Task).ConfigureAwait(false);
 
             if (cancellationToken.IsCancellationRequested)
                 await WaitForLatecomers(runners).ConfigureAwait(false);