Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We are unable to build our project with Node 12 dativebase/dative#324, we added a test to eco and found that the latest eco master does resolve this issue cesine/eco#9.
Is the -rc ready for use?
Before eco was archived, it had a few release candidates that were published https://www.npmjs.com/package/eco
While these are
-rc
release candidates which we would normally not pull in, eco is now archived so there wont be any future releases from the official repo.The new 1.1.0-rc release candidates, and eco master, has an important improvement for handling escaping and sanitizing input. I found several forks which have been using (and building upon) the new release candidates https://github.com/cesine/eco/pulls.
I found that the new -rc have a breaking change where compile is now returning a bare function sstephenson/eco@8ab3bec
We are able to take this -rc into grunt-eco without affecting grunt-eco's interface, which means consumers will be able to get the updates via a minor version on grunt-eco.
How this was tested
Update to 1.1.0-rc-3 sstephenson/eco@v1.0.3...v1.1.0-rc-3
update tasks to match new interface feab960
Manually test the resulting templates using amd in a consuming project
Travis results https://travis-ci.com/github/cesine/grunt-eco/builds/176743879