Custom ids #144
Custom ids #144
Conversation
- You can now set custom CSS ids for admonishment blocks with the `id` field. - You can now customize the default CSS id prefix (default is `"admonition-"`).
|
Hi - just commenting briefly to say thanks for the contribution! I'm mid review, got interrupted by some Life, but hope to pick up in the next week. On board with the idea though 👍 |
- You can now set custom CSS ids for admonishment blocks with the `id` field. - You can now customize the default CSS id prefix (default is `"admonition-"`).
There was a problem hiding this comment.
This is excellent work, thank you very much!
I made changes while I was reviewing. I've rebased and pushed this to a new branch sky9-review (as I can't update Sky9x:main). You can see the review changes here: main...sky9-review
Mostly this was just moving code around to make types match up, after my comments. If you're happy with the changes I've made, please update this PR to match and we can get it merged. Also happy to chat more about any of the changes if you have further thoughts.
|
strange that you cant edit my branch as i have "allow edits by maintainers" enabled but 🤷 resolved merge conflicts with upstream/main, accepted all your changed, and added my final nitpicks im done unless you have anything else otherwise its good to go |
idfield."admonition-").Feel free to nitpick everything (doc wording etc)