Escape regex metacharcters when constructing search term RegExp from … #52

ahutchings · 2017-02-12T22:54:15Z

…user input

Without escaping, user input such as "[" or "*" trigger an uncaught SyntaxError: "Invalid regular expression: /^(?:.* +)*[/: Unterminated character class"

…user input Without escaping, user input such as "[" or "*" trigger an uncaught SyntaxError: "Invalid regular expression: /^(?:.* +)*[/: Unterminated character class"

tommoor · 2017-02-12T23:53:02Z

Killing it, btw I just switched to using prettier to auto format the code - does away with opinions which is great on OS projects like this :) Just wanted to let you know incase you do any more PR's master was just linted and updated with that formatting which changed a bunch of files.

ahutchings · 2017-02-13T00:20:56Z

Nice, I've been meaning to check out prettier. Will definitely update before sending any PR's!

Escape regex metacharcters when constructing search term RegExp from …

ea5263b

…user input Without escaping, user input such as "[" or "*" trigger an uncaught SyntaxError: "Invalid regular expression: /^(?:.* +)*[/: Unterminated character class"

tommoor merged commit ea5263b into tommoor:master Feb 12, 2017

ahutchings deleted the bugfix/escape-regexp branch February 13, 2017 00:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Escape regex metacharcters when constructing search term RegExp from … #52

Escape regex metacharcters when constructing search term RegExp from … #52

ahutchings commented Feb 12, 2017 •

edited

tommoor commented Feb 12, 2017

ahutchings commented Feb 13, 2017

Escape regex metacharcters when constructing search term RegExp from … #52

Escape regex metacharcters when constructing search term RegExp from … #52

Conversation

ahutchings commented Feb 12, 2017 • edited

tommoor commented Feb 12, 2017

ahutchings commented Feb 13, 2017

ahutchings commented Feb 12, 2017 •

edited