-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not properly render "👩⚕️" #26
Comments
That's because the emoji is not in the list of aliases, so the library doesn't transform it: https://github.com/tommoor/react-emoji-render/blob/master/data/aliases.js |
Aren't the aliases for doing the |
This project creates a url of Here's a modification of the demo to show this: http://requirebin.com/?gist=fc94a8e4e0cec4b27f74674bd53d8e9a |
Yes you are right, the aliases are just for Github/Slack emojis. However when you just paste the unicode character, it still get parsed so the React component can fetch the image to display. That image URL is created to match the UTF Code Point, which as the EmojiOne page points out , it's correct in this case: (https://www.emojione.com/emoji/1f469-2695) I think the actual reason it's not working is because that emoji wasn't in EmojiOne 2.2.7, so no way the image could be loaded because it didn't exist on the CDN at the first place, even at other URL or whatever. List of emojis in 2.2: https://emojipedia.org/emojione/2.2/. Supporting EmojiOne 4.0 would solve this but I don't feel like working on upgrading the version without knowing @tommoor opinion on it as it's kind of a boring thing to do and I don't have publishing right on the library so I'm not even sure if it will be actually published :) |
I think it has to do with the EmojiOne URL scheme, as I mentioned in the OP EmojiOne has it at https://cdn.jsdelivr.net/emojione/assets/4.0/png/128/1f469-2695.png but the URL this library generates is this one, which does not work: https://cdn.jsdelivr.net/emojione/assets/4.0/png/128/1f469-200d-2695-fe0f.png |
I'm working on upgrading to EmojiOne 4.0, we will see later if this issue remains. |
I am unable to get the character 👩⚕️to render properly.
https://www.emojione.com/emoji/1f469-2695
It's available in Emojione 4.0 (#25) at https://cdn.jsdelivr.net/emojione/assets/4.0/png/128/1f469-2695.png
The text was updated successfully, but these errors were encountered: