Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EmojiOne to 4.0 #25

Closed
wilg opened this issue Oct 2, 2018 · 3 comments · Fixed by #28
Closed

Update EmojiOne to 4.0 #25

wilg opened this issue Oct 2, 2018 · 3 comments · Fixed by #28

Comments

@wilg
Copy link

wilg commented Oct 2, 2018

This project uses EmojiOne 2.x, but there is a 4.0 version with more up-to-date icons. It's on a different CDN though: https://cdn.jsdelivr.net/emojione/assets/4.0/png/128/1f600.png

@enzoferey
Copy link
Collaborator

enzoferey commented Oct 31, 2018

As I answered you in the other issue, to render that emoji we would need to update the EmojiOne cdn version (if the emoji didn't exist in 2.x) and then add it to the list of aliases.

Feel free to do those changes, pretty sure @tommoor will be glad to add them :)

@tommoor
Copy link
Owner

tommoor commented Nov 4, 2018

Very happy to accept a PR – I don't think it would be too involved but I'm not currently using this library in any production projects so not top of list for me.

@enzoferey
Copy link
Collaborator

All right, I will work on that. I feel like it's good for the future of the library, we will be able to support much more emojis ! Expect a PR from me by the end of the week ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants