Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assume <link> tags are all in <head> #90

Closed
dvdplm opened this issue Mar 20, 2017 · 3 comments
Closed

Do not assume <link> tags are all in <head> #90

dvdplm opened this issue Mar 20, 2017 · 3 comments

Comments

@dvdplm
Copy link
Contributor

dvdplm commented Mar 20, 2017

Ran into a strange issue today on a site with unusual markup. They have their tag with the favicon in the tag (don't ask me why!) which causes Tinycon to fail in removeFaviconTag() at load because it is trying to remove a link-node that is not a child of head.
The fix is fairly straight forward: dvdplm@7e8b207
@tommoor
Copy link
Owner

tommoor commented Mar 26, 2017

Hey @dvdplm - makes sense, want to put in a PR?

@dvdplm
Copy link
Contributor Author

dvdplm commented Mar 27, 2017

@tommoor will do. (Our fork has diverged a little but will redo against master)

@dvdplm dvdplm mentioned this issue Mar 29, 2017
Merged
@tommoor
Copy link
Owner

tommoor commented Apr 1, 2017

closed by 3a60dfe

@tommoor tommoor closed this as completed Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dvdplm @tommoor