Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operations inside return statements are not being detected. #11

Closed
Ryan1729 opened this issue Aug 21, 2020 · 2 comments
Closed

Operations inside return statements are not being detected. #11

Ryan1729 opened this issue Aug 21, 2020 · 2 comments
Assignees
@tommy-muehle
Labels
bug Something isn't working

Comments

@Ryan1729
Copy link

Currently no magic numbers are detected in the following code:

func foo(x int32) int32 {
	return x + 42
}

Even though the magic number is detected in this code:

func foo() int32 {
	return 42
}
@Ryan1729 Ryan1729 mentioned this issue Aug 21, 2020
Open
@tommy-muehle tommy-muehle self-assigned this Aug 31, 2020
@tommy-muehle tommy-muehle added the bug Something isn't working label Aug 31, 2020
@tommy-muehle
Copy link
Owner

@Ryan1729
Thanks for the report.

tommy-muehle added a commit that referenced this issue Sep 23, 2020
@tommy-muehle
Check also binary expressions in return statement, fixes #11
f03ec7f
@tommy-muehle
Copy link
Owner

@Ryan1729 Thanks again for your report. I fixed this bug with version 2.0.2. Feel free to try it out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommy-muehle tommy-muehle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tommy-muehle @Ryan1729