-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Disk Scraper Metrics #4
Add support for Disk Scraper Metrics #4
Conversation
timestamp := dp.Timestamp() | ||
value := dp.IntValue() | ||
|
||
switch direction.Str() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L26-34 can be simplified to just addDiskIntMetric(metrics, resource, dataset, metric.Name(), device, direction.Str(), dp.Timestamp(), dp.IntValue())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
|
||
metricsToAdd := map[string]string{ | ||
"system.disk.operation_time": "system.diskio.%s.time", | ||
"system.disk.io_time": "system.disk.%s.time", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this meant to be diskio
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks
The code for disk scraper is now present here. |
Adds metrics for the Disk Scraper.
Link to tracking Issue:
https://github.com/elastic/opentelemetry-dev/issues/181