-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening directory dialog crashes liftoff #101
Comments
Spooky timing! crashinvaders/gdx-texture-packer-gui#138 was created just today - very similar. |
I'll take a look... Hmm... |
This looks like there's an I18N issue with VisUI's FileChooser, which I don't think 1.11.0.1 even uses (it uses NFD, Native File Dialogs). Maybe on Windows 11 (which I don't have), NFD can't work and falls back to VisUI's FileChooser, but that seems unlikely... |
All I can tell is that NFD is crashing (which has never happened to me, but I'm on Windows 10), so VisUI's FileChooser is used instead, and that looks for the I18N string |
Yeah, the patch works fine. Aaaaaand... I found the reason for this issue! The problem seems to be located in the lwjgl handling when two applications are open, that both uses NFD. Interesting observation: Here's a debug output, that shows what happens. At the end there is an AccessDeniedException, because a file should be deleted, but of course cannot, as it is in use.
|
I don't think there's anything I can do about this, since it seems to be on LWJGL3's side. I can't even reproduce it by opening and closing NFD-using apps (I am on Windows 10, using I think Java 16). We do know now that a potential solution is to only use one app that uses NFD at a time, which isn't ideal, but I'm glad you found it. I added some logging code so if users are running from the command line, they should see the NFD stack trace and also get a message about trying to avoid using multiple LWJGL3 apps at once. I'll close this because I don't think Liftoff's code can do any more, but I might open an issue with LWJGL3 if I can reproduce. You can open an issue there instead, and since you actually can encounter the bug and maybe get more info in the process, that might help them figure out a solution. |
System
OS: Windows 11
Java: OpenJDK 16
gdx-liftoff: 1.11.0.1 (and above)
Steps
Result
Note
Up to version 1.11.0.0 (including) liftoff works absolutely fine. This problem occurs first with 1.11.0.1 and then in all subsequent releases.
The text was updated successfully, but these errors were encountered: