POST to route returns 404

[AllSpeeds]

GIVEN route table:

"router": {
        "options": {
          "routes": {
            "someGetRoute": {
              "method": "GET",
              "name": "someGetRoute",
              "path": "/someGetRoute",
              "description": "Example GET route",
              "handler": "someGetRoute",
              "params": {},
              "enabled": true
            },
            "somePostRoute": {
              "method": "POST",
              "name": "somePostRoute",
              "path": "/somePostRoute",
              "description": "Example POST route",
              "handler": "somePostRoute",
              "params": {},
              "enabled": true
            }
}
}
}

WHEN looping over routes looking for a match
AND when matched
AND when method matches
THEN move on

Currently, this code (https://github.com/tommymessbauer/pipeline-router/blob/master/index.js#L123):

    // quick fail check
    if (matched || httpContext.request.method !== options.method) {
      next();
    }

will not find a match OR the method will not match and fire next() and end with match undefined which returns a 404 as the POST response:

this.plRouter.on('end', function(err, results) {
    var matched = results[0].matched,
        res = results[0].httpContext.response;

    that.emit('end', err, results);

    if ((!matched || err) && res) {
      res.statusCode = 404;
      res.write("No matching route or failed route");
      res.end(err ? err.stack : '');
    }
  });

[AllSpeeds]

Forked, writing a test with a route table and going to submit a PR.

[panthershark]

Route tables are part of https://github.com/mixdown/router, not pipeline-router.

[panthershark]

next() does not end the pipeline. It tells the pipeline to try the next step.

[AllSpeeds]

@tommymessbauer You're right, next() does not necessarily end the pipeline. You're also right about the route table, however are you saying the fix for this is in mixdown-router? The code path still breaks.

[panthershark]

I am just saying that you cannot initialize a pipeline router with a route table. Mixdown-router uses a route table.

[AllSpeeds]

yeah and you said it 6 times....I get it.

[panthershark]

I promise that was a github bug. I pressed "Comment" and it did nothing. So it took 6 tries before I realized that the page was not updating correctly.