Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing H_1 (#45) #53

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Reducing H_1 (#45) #53

merged 2 commits into from
Jan 14, 2023

Conversation

hprshayan
Copy link
Contributor

Hi. I gave it a try in response to #45. Specifically, instead of propagating all items of each itemset to the _ap_genrules function, I only include the items that have confidence > min_confidence in H_1.

* Avoiding propagation of rhs items in H_1 with confidence < min_confidence
@tommyod
Copy link
Owner

tommyod commented Jan 14, 2023

Great! Thank you so much.

The linting is a bit strict, could you run black like in the Gh action?

black . -l 120;

@hprshayan
Copy link
Contributor Author

Done. Black does not compromise!

@tommyod tommyod merged commit 938e44a into tommyod:master Jan 14, 2023
@tommyod
Copy link
Owner

tommyod commented Jan 14, 2023

Merged. Thank you so much for this Shayan!

@selting selting mentioned this pull request Feb 1, 2023
tommyod pushed a commit that referenced this pull request Feb 2, 2023
* Fixing H_1 reduction update in #53 (#57)
* Avoiding passing empty H_1 to _ap_genrules function

* Empty H_1 test added (#57)

* project reformated with black v23.1.0

* Update test_apriori.py

Benchmark commit hash added to  test_apriori.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants