Replaced setup.py with pyproject.toml #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified build instruction in DEPLOY.md file Signed-off-by: Saad Mohsin Khan <saadk687@gmail.com>
|
Can you take a look at GH actions please? It's failing |
Changed build command.
Added command to install build
|
@tommyod I have changed the build command, and they are working now. Previously it was looking for setup.py file which in this PR is not part of the repository. |
|
Great work! Thanks a lot for the contribution @saad1998 - I really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have done the following:
I have tested it by running the build instructions mentioned in the DEPLOY.md file. I have also used validate-pyproject package to validate the pyproject file. Please let me know if anything is missing. Thanks.
Closes #71