Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiP-Mode would be a great addition #154

Closed
Icoryx opened this issue Jul 4, 2022 · 4 comments
Closed

PiP-Mode would be a great addition #154

Icoryx opened this issue Jul 4, 2022 · 4 comments
Assignees
Labels
feature request A desirable feature that should be added
Projects

Comments

@Icoryx
Copy link

Icoryx commented Jul 4, 2022

Is your feature request related to a problem? Please describe.
In the normal Twitchapp you can exit and watch any stream you had opened before in Picture-in-picture mode, while doing something else in another app. This is the only thing I'm missing from the normal twitch app and the only reason I still sometimes use it.

Describe the solution you'd like
If you exit the app while watching a stream the stream automatically goes into PiP-mode. You should be able to drag it around, pinch it to make the player bigger or smaller and maybe also a button to pause/play and get back into the app.

Describe alternatives you've considered
I sometimes just use the splitscreen function from android. It's not very good for alot of things tho as some apps don't support this and others which support it get way too small to properly use them.

Additional context
Example:
Screenshot_2022-07-04-23-19-35-27_f56d448df78e8512261d4bfbcb3978c7

@Icoryx Icoryx added the feature request A desirable feature that should be added label Jul 4, 2022
@Icoryx Icoryx closed this as completed Jul 8, 2022
@Icoryx
Copy link
Author

Icoryx commented Jul 8, 2022

Didn't see the headsup about PiP

@tommyxchow
Copy link
Owner

Reopening this issue as I managed to get PiP working on Android thanks to a neat little package (source).

Gonna do some more tests to make sure this is the best solution, but so far things are looking good. I'll also see if I can get the in-app PiP working as well so that we can browse other streams while watching.

pip-demo.webm

@tommyxchow tommyxchow reopened this Jul 25, 2022
@Icoryx
Copy link
Author

Icoryx commented Jul 25, 2022

Looks promising PagMan

tommyxchow added a commit that referenced this issue Jul 27, 2022
Optimized the chat so that resuming PiP does not cause stutters.

This new implementation makes it so that only the latest (100) messages are
rendered at any given time, rather than every single one.

Once autoscroll is disabled and we scroll up in chat, the most recent
messages will be added to a buffer to prevent shifting.

Essentially, I've made it so that the default chat shows only the (100)
most recent messages. When you want to scroll back, the chat will
silently switch to the version with the last (10000) messages, giving
the best of both worlds in performance and scrollback history.
tommyxchow added a commit that referenced this issue Jul 27, 2022
Since widgets are built bottom up in the chat, most of the benefits of
the `ListView.builder` are likely null.
tommyxchow added a commit that referenced this issue Jul 27, 2022
@tommyxchow tommyxchow self-assigned this Jul 29, 2022
@tommyxchow tommyxchow added this to To do in Todo via automation Jul 29, 2022
@tommyxchow
Copy link
Owner

Added in v2.1.0 (#164)

Todo automation moved this from To do to Done Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A desirable feature that should be added
Projects
Todo
  
Done
Development

No branches or pull requests

2 participants