Fix 7TV emotes not using custom names #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyxchow
deleted the
289-frosty-does-not-recognize-when-a-channel-has-a-custom-name-for-a-7tv-emote
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (#289).
This PR fixes a case where 7TV emotes were not being shown/parsed correctly if the channel had set a custom name for that emote.
With the 7TV V3 API, emotes have 2 different name fields, the first on the top level as
nameand the second indata->name. The former will change automatically if the channel has set a custom name for it, while the latter will not change and is the "real" name of the emote.I mistakenly thought the latter had the behavior of the former and used that field. Now, the former field will be used and checked to see if we should show the real name in the emote details.