Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 7TV zero-width emotes not working #292

Merged

Conversation

tommyxchow
Copy link
Owner

Fixes #290.

This PR makes it so that we parse the flags field from the 7TV V3 API to check if an emote is zero-width

Previously, the tags field was being parsed to determine if it was zero-width. Turns out, not all zero-width emotes have this set (the tags are probably for something else, like for rendering/filtering on clients).

It doesn't seem to be documented, but based on looking at different emotes in the responses, the flags field appears to be responsible for the zero-width ability. If set to 0 it means a normal emote and 1 means zero-width. This field is now checked to determine if an emote is zero-width.

@tommyxchow tommyxchow added the bug fix A fix for a bug label Nov 1, 2023
@tommyxchow tommyxchow self-assigned this Nov 1, 2023
@tommyxchow tommyxchow linked an issue Nov 1, 2023 that may be closed by this pull request
@tommyxchow tommyxchow merged commit 1cb04be into main Nov 1, 2023
1 check passed
@tommyxchow tommyxchow deleted the 290-7tv-emotes-that-should-overlap-do-not-on-clientside branch November 1, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7tv emotes that should overlap do not on clientside
1 participant