Fix 7TV zero-width emotes not working #292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290.
This PR makes it so that we parse the
flags
field from the 7TV V3 API to check if an emote is zero-widthPreviously, the
tags
field was being parsed to determine if it was zero-width. Turns out, not all zero-width emotes have this set (the tags are probably for something else, like for rendering/filtering on clients).It doesn't seem to be documented, but based on looking at different emotes in the responses, the
flags
field appears to be responsible for the zero-width ability. If set to0
it means a normal emote and1
means zero-width. This field is now checked to determine if an emote is zero-width.