Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recent emotes not clearing #301

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

tommyxchow
Copy link
Owner

This PR fixes the "Recent" panel in the emote menu not clearing.

During the Material 3 refactor, I forgot to handle the clear behavior when confirming on the alert dialog. I've simply added back the clear method when tapping "Yes" on the alert dialog.

I've also wrapped the recent emote panel with the Observer widget so that the clear will be properly rebuilt.

@tommyxchow tommyxchow added the bug fix A fix for a bug label Nov 24, 2023
@tommyxchow tommyxchow self-assigned this Nov 24, 2023
@tommyxchow tommyxchow merged commit 59b15ff into main Nov 24, 2023
1 check passed
@tommyxchow tommyxchow deleted the fix-recent-emotes-not-clearing branch November 24, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant