Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom overlay player and add information about latency #313

Merged
merged 5 commits into from
Dec 21, 2023

Conversation

Artiu
Copy link
Contributor

@Artiu Artiu commented Dec 8, 2023

No description provided.

@tommyxchow tommyxchow self-assigned this Dec 9, 2023
@tommyxchow tommyxchow added improvement A change that tweaks or improves upon an existing feature new feature An addition that does not already exist labels Dec 9, 2023
@tommyxchow
Copy link
Owner

Thank you again, Artiu, for the PRs! Sadly I'm a bit busy for the next few days so I'll try to get back to your PRs later this week.

In the meantime, if possible can you add to the PRs a brief summary of the changes/implementation details? It'll help me get a better overall idea and speed up the review process (in case certain things aren't obvious like design choices or certain logic).

@Artiu
Copy link
Contributor Author

Artiu commented Dec 13, 2023

Changes:

  • added latency display,
  • update video player (current custom player have problem with hidden loading spinner, so in this version I'm hiding only necessary elements instead of whole twitch overlay)

@tommyxchow
Copy link
Owner

Hey @Artiu, apologies for the delay and thanks for your patience!

I did a quick test on my device and noticed that the info portion of the Twitch overlay appears for a brief moment now. Is there a way we can hide this as well?

screen-20231217-215315.mp4

@Artiu
Copy link
Contributor Author

Artiu commented Dec 20, 2023

I found different way to hide twitch overlay faster. So now overlay is not visible.

Copy link
Owner

@tommyxchow tommyxchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you so much!

@tommyxchow tommyxchow merged commit c58eda9 into tommyxchow:main Dec 21, 2023
1 check passed
@Artiu Artiu deleted the improve-custom-overlay-player branch April 17, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement A change that tweaks or improves upon an existing feature new feature An addition that does not already exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants