Fix quality selection and latency stats using an asyncQuerySelector #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into why stream qualities weren't displaying for me on the custom overlay, and found it was occurring because after clicking the ⚙️ settings button on the player, the menu doesn't appear until a split second later.
To fix this, I've updated the stream quality methods to use a new
asyncQuerySelector
instead ofdocument.querySelector
. I had to apply the same fix to the latency stats to ensure consistent stream quality behaviour, as they also interact with the settings menu.This change to using async JS code means that awaiting for
videoWebViewController.runJavaScript
no longer guarantees that the previous task actually completed, which was causing issues with the currentdefaultToHighestQuality
logic. I resolved this by updating this setting to call a new_setStreamQualityIndex(1)
instead. This also has the benefit of not "flashing" the settings menu twice when usingdefaultToHighestQuality
without the custom overlay.Fixes #338 (and maybe #334?)