Better logger file handling

tomnomnom · Mar 2, 2012 · 64b4a8f · 64b4a8f
1 parent d1081cb
commit 64b4a8f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/Library/Factory/Logger.php b/Library/Factory/Logger.php
@@ -8,8 +8,16 @@ public function make(){
       case 'file':
         // Make relative files relative to the config file
         $file = $this->settings->log['file'];
-        if (!is_writable($file)){
-          throw new \InvalidArgumentException("[{$file}] is not writable");
+        if (file_exists($file)){
+          if (!is_writable($file)){
+            throw new \InvalidArgumentException("[{$file}] is not writable");
+          }
+        } else {
+          if (is_writeable(dirname($file))){
+            touch($file);
+          } else {
+            throw new \InvalidArgumentException("[".dirname($file)."] is not writable; could not create log file");
+          }
         }
         if (in_array(substr($file, 0, 2), array('./', '..'))){
           $file = __DIR__.'/../../'.$file; 

diff --git a/config.example.ini b/config.example.ini
@@ -5,13 +5,13 @@ token           = ""
 token_secret    = ""
 
 [log]
-; Possible values are "file" and "null"
+; Possible values are "file", "screen" and "null"
 type  = "file"
 
 ; Possible values are "EMERGE", "ALERT", "CRIT", "ERR", "WARN", "NOTICE", "INFO" and "DEBUG"
 level = "INFO"
 
-file  = "/var/log/tvyv.log"
+file  = "/tmp/vimeo-uploader.log"
 
 [debug]
 ; Set to "true" to not actually upload videos