-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Switch to enable/disable urls from subdomains of base domain #3
Comments
Also, note, I did try to implement this, but Go doesn't like me... I tried to add a CMD param like so:
and then pass it into the functions getWaybackURLs and getCommonCrawlURLs via this:
Once I modified the resulting functions to look like this:
But Go didn't like that... I don't speak Go hahaha. |
Hey, @Rhynorater! Good idea :) I'll have a poke at it now |
I've added a The only real problem with it is that the searches still often include subdomains, so the actual behaviour doesn't quite line up with the expected behaviour. I'll add some additional filtering I think |
@Rhynorater I've added some output filtering so you only get results for the exact input domain if you specify the Give it a try and let me know if you hit any problems :) |
Thanks Tom! Sounds great!
…On Tue, Aug 28, 2018 at 11:53 AM, Tom Hudson ***@***.***> wrote:
I've added a --no-subs option in 41bb26a
<41bb26a>
The only real problem with it is that the searches still often include
subdomains, so the actual behaviour doesn't *quite* line up with the
expected behaviour.
I'll add some additional filtering I think
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC2_r0a33rDEPuQeWmSFHeicYg0MYgs9ks5uVWdwgaJpZM4WPnr3>
.
--
Justin Gardner
Cell: (804)525-8089
|
Hey Tom!
Great tool! I was wondering if it would be possible for you to add a command-line arg to select URLs only from the base domain provided. The new WayBack Machine query would look like this:
as opposed to the one that pulls all subdomains too (currently in your code) which is this:
I propose that this param should be called "with_subs" and should be Boolean defaulting to True.
Thanks,
Justin
The text was updated successfully, but these errors were encountered: