Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigation of F2 coefficient of ast_args() #671

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fenrir-naru
Copy link

According to pp.23 of Chapter.5 of IERS Conventions (1996), F2 coefficient for 3rd power of t is -0.000136, not 0.000136.

According to pp.23 of Chapter.5 of IERS Conventions (1996), F2 coefficient for 3rd power of t is -0.000136, not 0.000136.
@tomojitakasu
Copy link
Owner

I checked the reference but did not find any problem.

https://iers-conventions.obspm.fr/conventions_archive.php

Show your reference.

@fenrir-naru
Copy link
Author

Thank you for your comment.
The reference is link, and the direct link to Chapter.5 is here.

@tomojitakasu
Copy link
Owner

Thanks.

The PS version of IERS Conventions 1996 shows '+ 0".000136 t^3' in F2 (pp. 23).

https://iers-conventions.obspm.fr/archive/1996/ierscon.ps

The latest IERS Conventions (2010) also shows '+ 0.000136" t^3' in F2 (eq. 5.43, pp. 67).

https://www.iers.org/SharedDocs/Publikationen/EN/IERS/Publications/tn/TechnNote36/tn36_043.pdf

I'm not sure which is correct but the current code complies with IERS Conventions 2010.

@fenrir-naru
Copy link
Author

@tomojitakasu Thank you for your further investigation. I agree with your decision. If you like my PR with a comment about the reversion, please merge it, or just close this PR.

@fenrir-naru fenrir-naru changed the title Fix F2 coefficient of ast_args() Investigation of F2 coefficient of ast_args() Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants