Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pdf links with named destinations #140

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

przemech
Copy link

This adds support for named destinations described here:

mozilla/pdf.js#5258 (comment)

This also solves following issues:

@przemech
Copy link
Author

przemech commented Nov 12, 2022

This will work only with absolute filepath links:
file:///<absolute_path>/<filename>.pdf#<named_destination>

When using a relative path in the vscode, the path is resolved and the #<named_destination> is trimmed, so it gets lost before it reaches extension's code. Anyway, such link will not work on a GitHub repo, so proposed change is just a minor feature.

@przemech przemech changed the title Support for opening links with named destinations Some support for opening links with named destinations Nov 12, 2022
@przemech przemech changed the title Some support for opening links with named destinations Support for pdf links with named destinations Nov 25, 2022
@JBoysen1
Copy link

Yes - we need this. I use similar command line calls to open pdf in browsers. What would the VS code syntax on the command line look like ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants