Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing print event avoiding clash with VScode command palette + open file. #80 #85 #132 #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MStachowicz
Copy link

@MStachowicz MStachowicz commented Sep 8, 2023

While this may not be the optimal fix (adding keybind options to the keyboard shortcuts VS code window). This fixes the highly requested issue #80 #85 #132.

I think most people are using this extension as the name suggests, for pdfviewing. Printing can easily be done via a browser or adobe acrobat as an alternative. PDFs alongside code are used for reference.

@MStachowicz MStachowicz changed the title Removed the print key event to avoid clashing with VScode printing. #80 #85 #132 Removing print event avoiding clash with VScode command palette + open file. Closes #80 #85 #132 Sep 8, 2023
@MStachowicz MStachowicz changed the title Removing print event avoiding clash with VScode command palette + open file. Closes #80 #85 #132 Removing print event avoiding clash with VScode command palette + open file. #80 #85 #132 Sep 8, 2023
@ForsythsGambit
Copy link

Hello,

I have edited ~/.vscode/extensions/tomoki1207.pdf-1.2.2/lib/webviewer.js as you have in your commit, however the printing behavior still persists. Have you found a better method to supress this?

Thank you for your time,
~Liam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants